-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snowbridge: Synchronize from Snowfork repository (#3761) #4829
Snowbridge: Synchronize from Snowfork repository (#3761) #4829
Conversation
This PR includes the following 2 improvements: Author: @yrong - #123 - #125 The Ethereum client syncs beacon headers as they are finalized, and imports every execution header. When a message is received, it is verified against the import execution header. This is unnecessary, since the execution header can be sent with the message as proof. The recent Deneb Ethereum upgrade made it easier to locate the relevant beacon header from an execution header, and so this improvement was made possible. This resolves a concern @svyatonik had in our initial Rococo PR: paritytech#2522 (comment) Author: @yrong - #118 When the AH sovereign account (who pays relayer rewards) is depleted, the inbound message will not fail. The relayer just will not receive rewards. Both these changes were done by @yrong, many thanks. ❤️ --------- Co-authored-by: claravanstaden <Cats 4 life!> Co-authored-by: Ron <[email protected]> Co-authored-by: Vincent Geddes <[email protected]> Co-authored-by: Svyatoslav Nikolsky <[email protected]>
What kind of testing has been done on this backport? |
|
@yrong may you do a final review here before Parity reviews, please? :) |
prdoc/pr_3761.prdoc
Outdated
- audience: Runtime Dev | ||
description: | | ||
This PR improves the beacon client to send the execution header along with the message as proof and removes the verification and storing of all execution headers. | ||
If the AH sovereign account is depleted and relayer rewards cannot be paid, the message should still be processed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this still the case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not, removed in 1877257. :) Good catch
The CI pipeline was cancelled due to failure one of the required jobs. |
6dba07c
into
paritytech:release-crates-io-v1.7.0
@Morganamilo the PR description has been updated to contain full set of crates needing patch update publish |
This is a cherry-pick from master of #3761, excluding PR Snowfork#118
Expected patches for (1.7.0):